[ISSUE #10373] Fix quarantined flaky tests and remove CI rerun workflow#10379
Merged
Conversation
…workflow Fix root causes of flaky tests quarantined in apache#10374: - BloomFilterTest#testCheckFalseHit: use single seeded Random instance instead of per-character Random(System.nanoTime()) which produced duplicate strings in tight loops - TransactionalMessageServiceImplTest#testDeletePrepareMessage_maxSize: increase verify timeout from 50ms to 3000ms to accommodate slow thread scheduling - DefaultMQConsumerWithTraceTest#testPullMessage_WithTrace_Success: call pullMessage directly instead of async PullMessageService to eliminate race condition - DefaultMQLitePullConsumerWithTraceTest: set RebalanceService.waitInterval as static field in @before to avoid instance-level race condition Also remove rerun-workflow.yml to stop masking flaky tests with automatic CI retries.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #10379 +/- ##
==========================================
Coverage 48.88% 48.88%
+ Complexity 13450 13446 -4
==========================================
Files 1376 1376
Lines 100527 100527
Branches 12983 12983
==========================================
+ Hits 49144 49146 +2
+ Misses 45381 45355 -26
- Partials 6002 6026 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@Ignoreannotationsrerun-workflow.ymlto stop masking flaky tests with automatic CI retriesChanges
BloomFilterTest#testCheckFalseHitnew Random(System.nanoTime())per-character produced duplicate stringsRandom(42)instanceTransactionalMessageServiceImplTest#testDeletePrepareMessage_maxSizeverify(bridge, timeout(50))too short for slow CItimeout(3000)DefaultMQConsumerWithTraceTest#testPullMessage_WithTrace_SuccessPullMessageServicerace conditionpullMessagedirectlyDefaultMQLitePullConsumerWithTraceTest(2 methods)RebalanceService.waitIntervalrace@BeforeTest plan